Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Oct 28, 2024

Description

corresponding vsc PR: aws/aws-toolkit-vscode#5856

  • implicit(no @ workspace) chat invocation should be run with timeout 500ms
  • explicit(@ workspace) currently is the same and will not timeout

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested review from a team as code owners October 28, 2024 10:00
@Will-ShaoHua Will-ShaoHua marked this pull request as draft October 28, 2024 10:00
@Will-ShaoHua Will-ShaoHua changed the title refactor(amazonq): make queryChat suspend and called within withTimeout config(amazonq): make queryChat suspend and called within withTimeout Oct 28, 2024
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review November 11, 2024 20:40
@Will-ShaoHua
Copy link
Contributor Author

/retryBuilds

@Will-ShaoHua Will-ShaoHua merged commit aed4ab7 into aws:main Nov 13, 2024
12 of 13 checks passed
@Will-ShaoHua Will-ShaoHua deleted the query-chat-timeout branch November 13, 2024 19:52
dhasani23 pushed a commit to ntarakad-aws/aws-toolkit-jetbrains that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants